fix(stackable-versioned): Correctly emit enum fields in From impls #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
Techassi
force-pushed
the
fix/stackable-versioned-from-impl-enum-fields
branch
from
a462542 to
aba872e
Compare
sbernauer
approved these changes
Sep 2, 2025
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
I'm not sure I can follow the code 100%, but we have a test 😅
Member
Author
Is there anything I can help with? I can add a few comments to the code to explain what exactly it generates. |
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
|
Looking at |
Member
Author
|
Alright, cool. |
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly emits enum variant fields in
Fromimpl blocks. Encountered in stackabletech/secret-operator#634.